tilgalas commented on code in PR #36581:
URL: https://github.com/apache/beam/pull/36581#discussion_r2503908620
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/JavaBeanUtils.java:
##########
@@ -439,6 +441,13 @@ public ByteCodeAppender appender(final Target
implementationTarget) {
return (methodVisitor, implementationContext, instrumentedMethod) -> {
// this + method parameters.
int numLocals = 1 + instrumentedMethod.getParameters().size();
+ StackManipulation cast =
+ typeInformation
+ .getRawType()
+ .isAssignableFrom(
+
Preconditions.checkNotNull(typeInformation.getMethod()).getReturnType())
Review Comment:
pushed an update - I had to change some additional lines containing the
old-style `checkNotNull` invocations which made the PR somewhat larger-
hopefully it's still relatively easy to scan those changes while doing the
review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
