jrmccluskey commented on code in PR #36801:
URL: https://github.com/apache/beam/pull/36801#discussion_r2519194338


##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -131,8 +131,7 @@ class Pipeline(HasDisplayData):
   (e.g. ``input | "label" >> my_transform``).
   """
   @classmethod
-  def runner_implemented_transforms(cls):
-    # type: () -> FrozenSet[str]
+  def runner_implemented_transforms(cls) -> FrozenSet[str]:

Review Comment:
   Bit of a larger ask, but let's migrate these type hints away from the typing 
module to PEP-585 versions (https://peps.python.org/pep-0585/)
   
   e.g. the built-in `dict`, `list`, `tuple`,`set`, `frozenset` types, 
collections.abc for Iterable, Mapping, and Sequence



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to