scwhittle commented on code in PR #36631:
URL: https://github.com/apache/beam/pull/36631#discussion_r2522652990
##########
runners/google-cloud-dataflow-java/build.gradle:
##########
@@ -520,8 +519,7 @@ task validatesRunnerV2 {
excludedTests: [
'org.apache.beam.sdk.transforms.ReshuffleTest.testReshuffleWithTimestampsStreaming',
- // TODO(https://github.com/apache/beam/issues/18592): respect ParDo
lifecycle.
-
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testFnCallSequenceStateful',
Review Comment:
Triggering v1 and v2. The ExceptionThrowingFn in ParDoLifecycleTest only
works if dofn execution is in the same process as the pipeline.run(). Should
we add some new category of tests that require that so we can mark the tests
with that instead of the exclusion list? That could help other runners as well
and if we modify the test and remove the label they would automatically start
to run. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
