kennknowles commented on code in PR #36750:
URL: https://github.com/apache/beam/pull/36750#discussion_r2524159373
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/splittabledofn/RestrictionTrackers.java:
##########
@@ -101,8 +141,16 @@ protected RestrictionTrackerObserverWithProgress(
}
@Override
- public synchronized Progress getProgress() {
- return ((HasProgress) delegate).getProgress();
+ public Progress getProgress() {
Review Comment:
Following the existing code to check for breakage is good, but we also need
a super clear spec here. The `Progress` object has to be associated with a
restriction to have a meaning. So the caller needs to know what restriction it
is relative to. How should the caller be sure which restriction the Progress is
for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
