nielm commented on code in PR #36840:
URL: https://github.com/apache/beam/pull/36840#discussion_r2538930655
##########
sdks/python/apache_beam/io/gcp/tests/xlang_spannerio_it_test.py:
##########
@@ -118,76 +128,115 @@ def tearDown(self):
def test_spanner_insert_or_update(self):
self.spanner_helper.insert_values(
- self.database_id, [('or_update0', 5, False), ('or_update1', 9, False)])
+ self.database_id,
+ [('or_update0', 5, False, Timestamp.of(1234567890.0).to_rfc3339()),
Review Comment:
Please use a constant for this and the other locations it is used.
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/StructUtilsTest.java:
##########
@@ -286,6 +288,43 @@ public void
testStructTypeToBeamRowSchemaFailsTypeNotSupported() {
"Error processing struct to row: Unsupported type 'STRUCT'.",
exception.getMessage());
}
+ @Test
+ public void testStructToBeamRowWithMicrosInstant() {
+ Schema schema =
+ Schema.builder()
+ .addInt64Field("f_int64")
+ .addNullableField("f_micros_instant",
Schema.FieldType.logicalType(new MicrosInstant()))
+ .addNullableField(
+ "f_micros_instant_array",
+ Schema.FieldType.array(Schema.FieldType.logicalType(new
MicrosInstant())))
+ .build();
+
+ Timestamp ts = Timestamp.ofTimeMicroseconds(1234567890123456L);
Review Comment:
Please use a constant for this and in the expectedInstant calculations below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
