claudevdm commented on code in PR #36852:
URL: https://github.com/apache/beam/pull/36852#discussion_r2543462513
##########
sdks/python/apache_beam/typehints/native_type_compatibility.py:
##########
@@ -342,6 +342,7 @@ def convert_to_beam_type(typ):
# Unwrap Python 3.12 `type` aliases (TypeAliasType) to their underlying
value.
# This ensures Beam sees the actual aliased type (e.g., tuple[int, ...]).
+ import sys
Review Comment:
You can remove this (import was added back in another PR)
##########
sdks/python/conftest.py:
##########
@@ -34,6 +34,16 @@ def pytest_addoption(parser):
'--test-pipeline-options',
help='Options to use in test pipelines. NOTE: Tests may '
'ignore some or all of these options.')
+ parser.addoption(
+ '--enable-test-cleanup',
+ action='store_true',
+ default=None,
+ help='Enable expensive cleanup operations. Auto-enabled in CI.')
+ parser.addoption(
+ '--disable-test-cleanup',
Review Comment:
Why do we need two flags? Doesnt enable-test-cleanup=False mean the same as
disable-test-cleanup=True?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
