tarun-google commented on code in PR #36870:
URL: https://github.com/apache/beam/pull/36870#discussion_r2547283498
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java:
##########
@@ -175,8 +176,17 @@ static TypeAndMaxId beamFieldTypeToIcebergFieldType(
return new TypeAndMaxId(
--nestedFieldId,
BEAM_TYPES_TO_ICEBERG_TYPES.get(beamType.getTypeName()));
} else if (beamType.getTypeName().isLogicalType()) {
- String logicalTypeIdentifier =
- checkArgumentNotNull(beamType.getLogicalType()).getIdentifier();
+ Schema.LogicalType<?, ?> logicalType =
checkArgumentNotNull(beamType.getLogicalType());
+ if (logicalType instanceof FixedPrecisionNumeric) {
Review Comment:
not fully sure if this is the right way. But DecimalType need inputs of
precision and scale. which is not the case with other types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
