tomstepp commented on code in PR #36720:
URL: https://github.com/apache/beam/pull/36720#discussion_r2550363509
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java:
##########
@@ -596,4 +597,12 @@ private static Object getLogicalTypeValue(Object
icebergValue, Schema.FieldType
// LocalDateTime, LocalDate, LocalTime
return icebergValue;
}
+
+ public static <T> boolean isUnbounded(PCollection<T> input) {
+ return input.isBounded().equals(PCollection.IsBounded.UNBOUNDED);
+ }
+
+ public static boolean validDirectWriteLimit(@Nullable Integer
directWriteByteLimit) {
+ return directWriteByteLimit != null && directWriteByteLimit >= 0;
+ }
Review Comment:
Oh I understand this better now, done. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
