shunping commented on code in PR #15394:
URL: https://github.com/apache/beam/pull/15394#discussion_r2552138481
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java:
##########
@@ -454,8 +458,31 @@ public SeekableByteChannel open(GcsPath path) throws
IOException {
@VisibleForTesting
SeekableByteChannel open(GcsPath path, GoogleCloudStorageReadOptions
readOptions)
Review Comment:
I think we will need to add the logic to the code path of reading.
Btw, writing looks fine. The count metrics are implemented in the common
code path:
https://github.com/apache/beam/blob/b20ccbfe3efa147ea61b32438a44a31133046b4f/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java#L700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
