ibzib commented on pull request #12576: URL: https://github.com/apache/beam/pull/12576#issuecomment-694540273
> I'm a little unsure about the overhead this adds in terms of the number of options. Would it make sense to instead use the following format? For example: > > ``` > --environment_type PROCESS > --environment_option command=cmd > --environment_option variable='MY_ENV=XY' > ``` > > This would make it more clear what options belong to the environment. The current state of the PR would look like the following: > > ``` > --environment_type PROCESS > --env_process_command cmd > --env_process_variable 'MY_ENV=XY' > ``` > > My concern is that it is confusing to see the relationship between the environment type and the options. I like how this way creates a clearer hierarchy of options. I drafted an implementation based on how we handle --experiments. If you approve of this method, I will finish up the documentation work later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
