clairemcginty commented on PR #36838: URL: https://github.com/apache/beam/pull/36838#issuecomment-3572222825
> I suggest this: > > * Immediately, you can just set allowed skew to a large number and it will effectively disable the check. > * Short term, we can add a method to just disable the check entirely for a DoFn that has this computation pattern. > * Medium term, we can revise it to check against the watermark, after thinking a bit more to ensure this is going to be ok. Thanks @kennknowles! The immediate-term fix seems good and [our tests are now passing](https://github.com/spotify/scio/pull/5806/commits/25eb6a8946882bffd8a4bf06897fbd6e4a9d4ad3) - I had been hesitant to override the allowed skew since the method was marked deprecated, but with the short/medium term fixes we should be able to drop it eventually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
