damccorm commented on code in PR #36874:
URL: https://github.com/apache/beam/pull/36874#discussion_r2560582775
##########
sdks/python/apache_beam/transforms/enrichment_handlers/bigquery.py:
##########
@@ -141,11 +141,13 @@ def __init__(
self.project = project
self.column_names = column_names
self.select_fields = ",".join(column_names) if column_names else '*'
- self.row_restriction_template = row_restriction_template
+ self.row_restriction_template = (
+ row_restriction_template.replace('{{}}', '{}'))
self.table_name = table_name
self.fields = fields if fields else []
self.condition_value_fn = condition_value_fn
self.query_fn = query_fn
+ self._has_placeholders = '{}' in self.row_restriction_template
Review Comment:
I don't think we need to add a new feature to support {} placeholders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
