ehab20011 opened a new pull request, #36945:
URL: https://github.com/apache/beam/pull/36945
**Please** add a meaningful description for your change here
## Summary
Fixes #36857: Pass project-id to BigQuery Client in Beam Python SDK
Previously, `BigQueryWrapper` created the `google.cloud.bigquery.Client`
without explicitly passing the `project` parameter, causing it to fall back to
environment-based project inference. This led to failures in cross-project
scenarios, impersonation use cases, and environments where the project ID
wasn't available via environment variables or metadata server.
## Changes
- Modified `BigQueryWrapper.__init__` in `bigquery_tools.py` to explicitly
extract the project ID from `PipelineOptions` via `GoogleCloudOptions` and pass
it to `gcp_bigquery.Client()` constructor
- Added unit tests to verify:
- The BigQuery client is constructed with an explicit `project` kwarg
- Backward compatibility is maintained when a test client is injected
## Testing
- All existing `TestBigQueryWrapper` tests pass (29 tests)
- New tests verify the fix and backward compatibility
## Impact
This change ensures that BigQuery operations always use the project ID
specified in pipeline options, making the SDK more reliable in:
- Cross-project Dataflow pipelines
- Service account impersonation scenarios
- Airflow/Cloud Run environments
- Local development without environment variables
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
