damccorm commented on code in PR #36883:
URL: https://github.com/apache/beam/pull/36883#discussion_r2578530393
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java:
##########
@@ -78,6 +78,8 @@ public class FileSystems {
private static final Pattern FILE_SCHEME_PATTERN =
Pattern.compile("(?<scheme>[a-zA-Z][-a-zA-Z0-9+.]*):/.*");
private static final Pattern GLOB_PATTERN = Pattern.compile("[*?{}]");
+ private static final Pattern ESCAPED_GLOB_PATTERN =
Pattern.compile("\\\\[*?{}]");
+ private static final String GLOB_ESCAPE_PREFIX = "\\";
Review Comment:
I'm a bit confused - why are we making java changes for the python side
input pattern?
If there are additional changes needed beyond python side inputs, could you
please split them into a different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
