Abacn commented on code in PR #36961:
URL: https://github.com/apache/beam/pull/36961#discussion_r2581897220
##########
sdks/python/apache_beam/io/mongodbio.py:
##########
@@ -460,16 +457,15 @@ def _get_split_keys(
if self._range_is_not_splittable(start_pos, end_pos):
return []
- with MongoClient(self.uri, **self.spec) as client:
Review Comment:
this changed timing of client, made if from transient and auto-closing to
persistent.
I would prefer a fix not changing current behavior. Consider the following
1. Revert #36949
2. In `__init__`, update self.spec such that, if it does not contain a key
named "driver", set spec["driver"] = DriverInfo("Apache Beam", beam.__version__)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
