arunpandianp commented on code in PR #36830:
URL: https://github.com/apache/beam/pull/36830#discussion_r2582945672
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/IntervalWindow.java:
##########
@@ -186,8 +186,7 @@ public boolean consistentWithEquals() {
@Override
public boolean isRegisterByteSizeObserverCheap(IntervalWindow value) {
- return instantCoder.isRegisterByteSizeObserverCheap(value.end)
- && durationCoder.isRegisterByteSizeObserverCheap(new
Duration(value.start, value.end));
+ return true;
Review Comment:
inlining will require inlining overflow detection logic in Duration. I'll
keep it as it is for now and revisit if needed.
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java:
##########
@@ -411,5 +413,20 @@ public PaneInfo decode(final InputStream inStream) throws
CoderException, IOExce
@Override
public void verifyDeterministic() {}
+
+ @Override
+ protected long getEncodedElementByteSize(PaneInfo value) throws Exception {
Review Comment:
done.
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/ValueWithRecordId.java:
##########
@@ -124,6 +127,13 @@ public void verifyDeterministic() throws
NonDeterministicException {
valueCoder.verifyDeterministic();
}
+ @Override
+ public void registerByteSizeObserver(
Review Comment:
done.
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java:
##########
@@ -411,5 +413,20 @@ public PaneInfo decode(final InputStream inStream) throws
CoderException, IOExce
@Override
public void verifyDeterministic() {}
+
+ @Override
Review Comment:
done.
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java:
##########
@@ -411,5 +413,20 @@ public PaneInfo decode(final InputStream inStream) throws
CoderException, IOExce
@Override
public void verifyDeterministic() {}
+
+ @Override
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
