Abacn commented on PR #36271:
URL: https://github.com/apache/beam/pull/36271#issuecomment-3608380657

   > Can we add an integration test/validatesrunner test?
   
   Added a unit test. Tried to add a local integration test (run on prism 
runner) but find that Prism does not save/load sessions. Actually only 
service_runner (DataflowRunner) do.
   
   Now prefer to revert #35659 (and other workarounds) in follow ups, then the 
path is exercised by integration tests previously affected
   
   > Can we dump/load session by default if we detect that the user has used 
custom logical types? I dont think it is necessary for a user to control this 
via flag if we can detect, but maybe we can keep an option to explicitly 
disable it in case there are issues?
   
   Done. load session is now enabled by default for cloudpickle and introduced 
a "disable_save_main_session" flag to explicitly disable it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to