scwhittle commented on code in PR #36963:
URL: https://github.com/apache/beam/pull/36963#discussion_r2589935673
##########
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##########
@@ -761,6 +761,13 @@ message Elements {
// extensible and backward compatible
message ElementMetadata {
optional DrainMode.Enum drain = 1;
+ // (Optional) As part of https://www.w3.org/TR/trace-context/ we are
forwarding a trace and participating in it.
+ // Traceparent header represents the incoming request in a tracing system
in a common format.
+ // Example value: 00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01
+ optional string traceparent = 2;
+ // (Optional) tracestate extends traceparent with vendor-specific data
represented by a set of name/value pairs.
Review Comment:
If it is always name/value pairs, should we use a map?
If it is just vendor specific maybe it should just omit that it is set of
name/value pairs here or otherwise say for example opentelementry uses this
format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
