aaltay commented on a change in pull request #12727:
URL: https://github.com/apache/beam/pull/12727#discussion_r491168283
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -473,10 +474,19 @@ def run_pipeline(self, pipeline, options):
use_fnapi = apiclient._use_fnapi(options)
from apache_beam.transforms import environments
- self._default_environment = (
- environments.DockerEnvironment.from_container_image(
- apiclient.get_container_image_from_options(options),
- artifacts=environments.python_sdk_dependencies(options)))
+ if options.view_as(DebugOptions).lookup_experiment(
+ 'prebuild_sdk_container'):
Review comment:
Should this be a top level option similar to `docker_registry_push_url`
or vice versa? It probably make sense to make either both options an
experiment, or both as top level options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
