tvalentyn commented on code in PR #37042: URL: https://github.com/apache/beam/pull/37042#discussion_r2599734445
########## sdks/python/apache_beam/runners/portability/stager_test.py: ########## @@ -40,6 +40,9 @@ from apache_beam.runners.internal import names from apache_beam.runners.portability import stager +from concurrent.futures import ThreadPoolExecutor Review Comment: I think it's not worth adding a test to replicate this race, esp. since it is not a deterministic replication. I'd be fine to merge just the changes to `stager.py.` ########## sdks/python/apache_beam/runners/portability/stager_test.py: ########## @@ -40,6 +40,9 @@ from apache_beam.runners.internal import names from apache_beam.runners.portability import stager +from concurrent.futures import ThreadPoolExecutor Review Comment: I think it's not worth adding a test to replicate this race, esp. since it is not a deterministic replication. I'd be fine to merge just the changes to `stager.py` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
