hekk-kaori-maeda commented on PR #36832: URL: https://github.com/apache/beam/pull/36832#issuecomment-3630032449
@ahmedabu98 Thank you for the review! I've added unit tests for `BigQueryStorageApiInsertErrorCoder` in commit [a933d85]. The tests cover: - Basic encode/decode with all fields populated - Encode/decode with null `table` - Encode/decode with null `errorMessage` - Encode/decode with both nullable fields null Regarding update compatibility Since `BigQueryStorageApiInsertError` is used for error handling and typically not persisted across pipeline updates, I believe the current implementation follows the existing patterns. However, if you'd like me to add backward compatibility (e.g., version flag or field count check), please let me know. Could you also clarify your comment about "update compatibility"? I wasn't able to find the inline comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
