ahmedabu98 commented on code in PR #36509:
URL: https://github.com/apache/beam/pull/36509#discussion_r2603568032
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/CatalogManagerSchema.java:
##########
@@ -142,7 +145,8 @@ public void dropCatalog(SqlIdentifier identifier, boolean
ifExists) {
// will attempt to do so.
public void maybeRegisterProvider(TableName path, String type) {
type = type.toLowerCase();
- CatalogSchema catalogSchema = getCatalogSchema(path);
+ CatalogSchema catalogSchema =
+ path.catalog() != null ? getCatalogSchema(path) :
getCurrentCatalogSchema();
Review Comment:
Chose to make `getCatalogSchema()` responsible for resolving this logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
