ahmedabu98 commented on code in PR #36571: URL: https://github.com/apache/beam/pull/36571#discussion_r2604040689
########## sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/parser/SqlAlterCatalog.java: ########## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.extensions.sql.impl.parser; + +import static org.apache.beam.sdk.util.Preconditions.checkStateNotNull; +import static org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.util.Static.RESOURCE; +import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkState; + +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.beam.sdk.extensions.sql.impl.CatalogManagerSchema; +import org.apache.beam.sdk.extensions.sql.impl.CatalogSchema; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.jdbc.CalcitePrepare; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.jdbc.CalciteSchema; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.schema.Schema; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlAlter; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlIdentifier; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlKind; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlNode; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlNodeList; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlOperator; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlUtil; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlWriter; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.util.Pair; +import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableList; +import org.checkerframework.checker.nullness.qual.Nullable; + +public class SqlAlterCatalog extends SqlAlter implements BeamSqlParser.ExecutableStatement { + private static final SqlOperator OPERATOR = + new SqlSpecialOperator("ALTER CATALOG", SqlKind.OTHER_DDL); + private final SqlIdentifier name; + private final @Nullable SqlNodeList setProps; + private final @Nullable SqlNodeList resetProps; + + public SqlAlterCatalog( + SqlParserPos pos, + @Nullable String scope, + SqlNode name, + @Nullable SqlNodeList setProps, + @Nullable SqlNodeList resetProps) { + super(pos, scope); + this.name = SqlDdlNodes.getIdentifier(name, pos); + this.setProps = setProps; + this.resetProps = resetProps; + } + + @Override + public void execute(CalcitePrepare.Context context) { + final Pair<CalciteSchema, String> pair = SqlDdlNodes.schema(context, true, name); + Schema schema = pair.left.schema; + + if (!(schema instanceof CatalogManagerSchema)) { + throw SqlUtil.newContextException( + name.getParserPosition(), + RESOURCE.internal( + "Attempting to alter catalog '" + + SqlDdlNodes.name(name) + + "' with unexpected Calcite Schema of type " + + schema.getClass())); + } + + CatalogSchema catalogSchema = + ((CatalogManagerSchema) schema).getCatalogSchema(SqlDdlNodes.getString(name)); + + Map<String, String> setPropsMap = parseSetProps(); + Collection<String> resetProps = parseResetProps(); + + ImmutableList.Builder<String> overlappingPropsBuilder = ImmutableList.builder(); + resetProps.stream().filter(setPropsMap::containsKey).forEach(overlappingPropsBuilder::add); + List<String> overlappingProps = overlappingPropsBuilder.build(); + checkState( + overlappingProps.isEmpty(), + "Invalid %s call: Found overlapping properties between SET and RESET: %s.", + OPERATOR, + overlappingProps); + + catalogSchema.updateProperties(setPropsMap, resetProps); + } Review Comment: Nice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
