gemini-code-assist[bot] commented on PR #37094: URL: https://github.com/apache/beam/pull/37094#issuecomment-3646993263
## Summary of Changes Hello @damccorm, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the handling of `inference_args` within Beam's ML inference `ModelHandler` base class. It shifts the default behavior to allow `inference_args` to be passed, simplifying implementations for model handlers that support them. Concurrently, it enables specific handlers to explicitly disallow or utilize these arguments as needed, leading to more flexible and consistent argument management across different ML frameworks. ### Highlights * **Default Inference Args Handling**: The `ModelHandler` base class in `sdks/python/apache_beam/ml/inference/base.py` now permits `inference_args` by default, removing the previous `ValueError` that was raised if they were present. * **Streamlined Handler Implementations**: Several model handlers, including those for PyTorch, TensorFlow, and Vertex AI, have removed their explicit `validate_inference_args` overrides, as the new base class behavior makes them redundant. * **Explicit Arg Usage in Scikit-learn**: The Scikit-learn inference handler (`sdks/python/apache_beam/ml/inference/sklearn_inference.py`) has been updated to correctly pass `inference_args` to the `model.predict` method. * **Specific Arg Restriction for TensorRT**: The TensorRT inference handler (`sdks/python/apache_beam/ml/inference/tensorrt_inference.py`) now explicitly disallows `inference_args` by re-introducing a `ValueError` in its `validate_inference_args` method, indicating non-support for this specific framework. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
