assaf127 commented on code in PR #36979:
URL: https://github.com/apache/beam/pull/36979#discussion_r2637781196
##########
sdks/python/apache_beam/coders/coder_impl.py:
##########
@@ -616,6 +644,14 @@ def decode_from_stream(self, stream, nested):
msg = cls()
msg.ParseFromString(stream.read_all(True))
return msg
+ elif t == DATACLASS_KW_ONLY_TYPE:
+ cls = self.decode_type(stream)
+ vlen = stream.read_var_int64()
+ fields = {}
+ for _ in range(vlen):
+ field_name = stream.read_all(True).decode('utf-8')
+ fields[field_name] = self.decode_from_stream(stream, True)
Review Comment:
This suggestion less clear regarding the order of reads from the stream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
