ahmedabu98 commented on code in PR #37191:
URL: https://github.com/apache/beam/pull/37191#discussion_r2649573579
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/ReadUtils.java:
##########
@@ -208,4 +243,138 @@ public static CloseableIterable<Record> maybeApplyFilter(
}
return iterable;
}
+
+ public static DeleteFilter<Record> genericDeleteFilter(
+ Table table,
+ IcebergScanConfig scanConfig,
+ String dataFilePath,
+ List<SerializableDeleteFile> deletes) {
+ return new BeamDeleteFilter(
+ table.io(),
+ dataFilePath,
+ scanConfig.getRequiredSchema(),
+ scanConfig.getProjectedSchema(),
+ deletes.stream()
+ .map(sdf -> sdf.createDeleteFile(table.specs(),
table.sortOrders()))
+ .collect(Collectors.toList()));
+ }
+
+ public static DeleteReader<Record> genericDeleteReader(
+ Table table,
+ IcebergScanConfig scanConfig,
+ String dataFilePath,
+ List<SerializableDeleteFile> deletes) {
+ return new BeamDeleteReader(
+ table.io(),
+ dataFilePath,
+ scanConfig.getRequiredSchema(),
+ scanConfig.getProjectedSchema(),
+ deletes.stream()
+ .map(sdf -> sdf.createDeleteFile(table.specs(),
table.sortOrders()))
+ .collect(Collectors.toList()));
+ }
+
+ public static class BeamDeleteFilter extends DeleteFilter<Record> {
+ private final FileIO io;
+ private final InternalRecordWrapper asStructLike;
+
+ @SuppressWarnings("method.invocation")
+ public BeamDeleteFilter(
+ FileIO io,
+ String dataFilePath,
+ Schema tableSchema,
+ Schema projectedSchema,
+ List<DeleteFile> deleteFiles) {
+ super(dataFilePath, deleteFiles, tableSchema, projectedSchema);
+ this.io = io;
+ this.asStructLike = new
InternalRecordWrapper(requiredSchema().asStruct());
+ }
+
+ // TODO: remove this (unused)
+ @SuppressWarnings("method.invocation")
+ public BeamDeleteFilter(
+ FileIO io,
+ SerializableChangelogTask scanTask,
+ Schema tableSchema,
+ Schema projectedSchema,
+ List<DeleteFile> deleteFiles) {
+ super(scanTask.getDataFile().getPath(), deleteFiles, tableSchema,
projectedSchema);
+ this.io = io;
+ this.asStructLike = new
InternalRecordWrapper(requiredSchema().asStruct());
+ }
+
+ // TODO: remove this (unused)
+ @SuppressWarnings("method.invocation")
+ public BeamDeleteFilter(FileIO io, ContentScanTask<?> scanTask,
List<DeleteFile> deleteFiles) {
+ super(
+ scanTask.file().location(),
+ deleteFiles,
+ scanTask.spec().schema(),
+ scanTask.spec().schema());
+ this.io = io;
+ this.asStructLike = new
InternalRecordWrapper(requiredSchema().asStruct());
+ }
Review Comment:
Ignore this for now
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/ReadUtils.java:
##########
@@ -208,4 +243,138 @@ public static CloseableIterable<Record> maybeApplyFilter(
}
return iterable;
}
+
+ public static DeleteFilter<Record> genericDeleteFilter(
+ Table table,
+ IcebergScanConfig scanConfig,
+ String dataFilePath,
+ List<SerializableDeleteFile> deletes) {
+ return new BeamDeleteFilter(
+ table.io(),
+ dataFilePath,
+ scanConfig.getRequiredSchema(),
+ scanConfig.getProjectedSchema(),
+ deletes.stream()
+ .map(sdf -> sdf.createDeleteFile(table.specs(),
table.sortOrders()))
+ .collect(Collectors.toList()));
+ }
+
+ public static DeleteReader<Record> genericDeleteReader(
+ Table table,
+ IcebergScanConfig scanConfig,
+ String dataFilePath,
+ List<SerializableDeleteFile> deletes) {
+ return new BeamDeleteReader(
+ table.io(),
+ dataFilePath,
+ scanConfig.getRequiredSchema(),
+ scanConfig.getProjectedSchema(),
+ deletes.stream()
+ .map(sdf -> sdf.createDeleteFile(table.specs(),
table.sortOrders()))
+ .collect(Collectors.toList()));
+ }
+
+ public static class BeamDeleteFilter extends DeleteFilter<Record> {
+ private final FileIO io;
+ private final InternalRecordWrapper asStructLike;
+
+ @SuppressWarnings("method.invocation")
+ public BeamDeleteFilter(
+ FileIO io,
+ String dataFilePath,
+ Schema tableSchema,
+ Schema projectedSchema,
+ List<DeleteFile> deleteFiles) {
+ super(dataFilePath, deleteFiles, tableSchema, projectedSchema);
+ this.io = io;
+ this.asStructLike = new
InternalRecordWrapper(requiredSchema().asStruct());
+ }
+
+ // TODO: remove this (unused)
+ @SuppressWarnings("method.invocation")
+ public BeamDeleteFilter(
+ FileIO io,
+ SerializableChangelogTask scanTask,
+ Schema tableSchema,
+ Schema projectedSchema,
+ List<DeleteFile> deleteFiles) {
+ super(scanTask.getDataFile().getPath(), deleteFiles, tableSchema,
projectedSchema);
+ this.io = io;
+ this.asStructLike = new
InternalRecordWrapper(requiredSchema().asStruct());
+ }
+
+ // TODO: remove this (unused)
+ @SuppressWarnings("method.invocation")
+ public BeamDeleteFilter(FileIO io, ContentScanTask<?> scanTask,
List<DeleteFile> deleteFiles) {
+ super(
+ scanTask.file().location(),
+ deleteFiles,
+ scanTask.spec().schema(),
+ scanTask.spec().schema());
+ this.io = io;
+ this.asStructLike = new
InternalRecordWrapper(requiredSchema().asStruct());
+ }
+
+ @Override
+ protected StructLike asStructLike(Record record) {
+ return asStructLike.wrap(record);
+ }
+
+ @Override
+ protected InputFile getInputFile(String location) {
+ return io.newInputFile(location);
+ }
+ }
+
+ public static class BeamDeleteReader extends DeleteReader<Record> {
+ private final FileIO io;
+ private final InternalRecordWrapper asStructLike;
+
+ @SuppressWarnings("method.invocation")
+ public BeamDeleteReader(
+ FileIO io,
+ String dataFilePath,
+ Schema tableSchema,
+ Schema projectedSchema,
+ List<DeleteFile> deleteFiles) {
+ super(dataFilePath, deleteFiles, tableSchema, projectedSchema);
+ this.io = io;
+ this.asStructLike = new
InternalRecordWrapper(requiredSchema().asStruct());
+ }
+
+ // TODO: remove this (unused)
+ @SuppressWarnings("method.invocation")
+ public BeamDeleteReader(
+ FileIO io,
+ SerializableChangelogTask scanTask,
+ Schema tableSchema,
+ Schema projectedSchema,
+ List<DeleteFile> deleteFiles) {
+ super(scanTask.getDataFile().getPath(), deleteFiles, tableSchema,
projectedSchema);
+ this.io = io;
+ this.asStructLike = new
InternalRecordWrapper(requiredSchema().asStruct());
+ }
+
+ // TODO: remove this (unused)
+ @SuppressWarnings("method.invocation")
+ public BeamDeleteReader(FileIO io, ContentScanTask<?> scanTask,
List<DeleteFile> deleteFiles) {
+ super(
+ scanTask.file().location(),
+ deleteFiles,
+ scanTask.spec().schema(),
+ scanTask.spec().schema());
+ this.io = io;
+ this.asStructLike = new
InternalRecordWrapper(requiredSchema().asStruct());
+ }
Review Comment:
Ignore this for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
