ShashidharM0118 opened a new pull request, #37195:
URL: https://github.com/apache/beam/pull/37195
This PR fixes a bug where
[StateTable](cci:2://file:///home/shashi/projects/beam/runners/core-java/src/main/java/org/apache/beam/runners/core/StateTable.java:37:0-116:1)
and
[CachingStateTable](cci:2://file:///home/shashi/projects/beam/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/CachingStateTable.java:39:0-324:1)
were only using the raw ID for equality checks, ignoring the system/user
prefix. This could lead to data corruption if a user-defined state tag happened
to share the same ID as a system-defined one.
### Changes:
- Added
[getIdWithPrefix()](cci:1://file:///home/shashi/projects/beam/runners/core-java/src/main/java/org/apache/beam/runners/core/StateTag.java:57:2-71:3)
to the
[StateTag](cci:2://file:///home/shashi/projects/beam/runners/core-java/src/main/java/org/apache/beam/runners/core/StateTag.java:49:0-128:1)
interface to expose the full identifier.
- Updated `StateTags.ID_EQUIVALENCE` and
[SimpleStateTag](cci:2://file:///home/shashi/projects/beam/runners/core-java/src/main/java/org/apache/beam/runners/core/StateTags.java:317:2-374:3)
to incorporate the prefix in equality and hash calculations.
- Modified
[CachingStateTable](cci:2://file:///home/shashi/projects/beam/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/CachingStateTable.java:39:0-324:1)
to use the prefixed ID in its internal
[StateTableKey](cci:2://file:///home/shashi/projects/beam/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/CachingStateTable.java:268:2-278:3).
- Added unit tests to verify that tags with the same ID but different
prefixes no longer collide.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Fixes #36753
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
