gemini-code-assist[bot] commented on PR #37248: URL: https://github.com/apache/beam/pull/37248#issuecomment-3720474038
## Summary of Changes Hello @jrmccluskey, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the type inference mechanism to be fully compatible with Python 3.14. It incorporates changes to CPython opcodes and their behaviors, along with refinements to native type compatibility, to ensure accurate and robust type inference in the latest Python environment. ### Highlights * **Python 3.14 Opcode Support**: The trivial inference state machine has been updated to recognize and correctly handle new CPython opcodes introduced in Python 3.14, such as `LOAD_SMALL_INT`, `POP_ITER`, `NOT_TAKEN`, and new `LOAD_FAST` variants like `LOAD_FAST_BORROW`. * **Updated Opcode Behavior**: Existing opcode behaviors have been adjusted for Python 3.14. Notably, `BINARY_SUBSCR` is now integrated into `symmetric_binary_op` as part of `BINARY_OP`, and the handling of `CALL_FUNCTION_EX` for keyword arguments now accounts for the `PUSH_NULL` opcode's role in signaling kwargs. * **Native Type Compatibility Enhancements**: The type compatibility code has been improved to correctly handle new behaviors for accessing `__args__` in bare types, ensuring that `typ.__args__` is validated as a tuple. A test case was also updated to reflect the use of `list['int']` instead of `typing.List['int']`, aligning with modern Python type hinting. * **Function Annotation Handling**: Logic has been added to `set_function_attribute` to correctly process new function annotation flags (`arg & 0x10`), ensuring proper handling of annotated functions in Python 3.14. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
