ahmedabu98 commented on code in PR #37253:
URL: https://github.com/apache/beam/pull/37253#discussion_r2674621615
##########
sdks/python/apache_beam/io/gcp/bigquery_schema_tools.py:
##########
@@ -49,6 +49,9 @@
"BYTES": bytes,
"TIMESTAMP": apache_beam.utils.timestamp.Timestamp,
"GEOGRAPHY": str,
+ "DATE": str,
Review Comment:
`DATE` and `DATETIME` aren't supported yet (only `TIMESTAMP`)
But I'm not very keen on defaulting them to Strings, it's not very robust.
We should choose a Python native type that is closer to what a DATE/DATETIME
actually is.
Some options are discussed in https://s.apache.org/beam-timestamp-strategy
(under "Python Nanosecond Support" --> "DateTime"). It'll take more work but I
think it's a better longterm solution for Beam.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
