damccorm commented on code in PR #37296:
URL: https://github.com/apache/beam/pull/37296#discussion_r2690889614
##########
sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py:
##########
@@ -309,9 +308,6 @@ def process(self, query, *unused_args, **unused_kwargs):
# e.code.value contains the numeric http status code.
service_call_metric.call(e.code.value)
raise
- except HttpError as e:
- service_call_metric.call(e)
- raise
Review Comment:
Is this safe to remove because we're already not using apitools for these
calls?
##########
sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py:
##########
@@ -309,9 +308,6 @@ def process(self, query, *unused_args, **unused_kwargs):
# e.code.value contains the numeric http status code.
service_call_metric.call(e.code.value)
raise
- except HttpError as e:
- service_call_metric.call(e)
- raise
Review Comment:
Same question applies elsewhere - will this let actual HttpErrors through if
we remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
