junaiddshaukat commented on PR #37214: URL: https://github.com/apache/beam/pull/37214#issuecomment-3750889798
Hi @damccorm, I tried using object-sizeof as you suggested, but it has Node.js compatibility issues (util.isPrimitive was removed in Node v22+) and doesn't handle circular references. Instead, I implemented a custom sizeof function with a visited Set to handle circular references (addressing gemini's critical concern), fixed the eviction ordering bug (now add-then-evict), and added the oversized item test case. All 292 tests pass locally. Let me know if you'd prefer a different approach! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
