damccorm commented on code in PR #37221:
URL: https://github.com/apache/beam/pull/37221#discussion_r2692356488
##########
sdks/python/apache_beam/runners/interactive/recording_manager.py:
##########
@@ -886,10 +887,11 @@ def record(
# Start a pipeline fragment to start computing the PCollections.
uncomputed_pcolls = set(pcolls).difference(computed_pcolls)
if uncomputed_pcolls:
- if not self._wait_for_dependencies(uncomputed_pcolls):
- raise RuntimeError(
- 'Cannot record because a dependency failed to compute'
- ' asynchronously.')
+ if wait_for_inputs:
+ if not self._wait_for_dependencies(uncomputed_pcolls):
+ raise RuntimeError(
+ 'Cannot record because a dependency failed to compute'
+ ' asynchronously.')
Review Comment:
Could you help me understand what use case you're trying to solve for here?
If I'm reading the PR right, you're not changing the default behavior, but you
are letting the recording manager get into a potentially bad state if the user
intentionally sets wait_for_inputs to false. Its not clear to me why this is
desireable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
