Abacn commented on code in PR #37319:
URL: https://github.com/apache/beam/pull/37319#discussion_r2699524326
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -679,6 +679,7 @@ class BeamModulePlugin implements Plugin<Project> {
activemq_mqtt :
"org.apache.activemq:activemq-mqtt:$activemq_version",
args4j : "args4j:args4j:2.33",
auto_value_annotations :
"com.google.auto.value:auto-value-annotations:$autovalue_version",
+ auto_value :
"com.google.auto.value:auto-value:$autovalue_version",
Review Comment:
see below, this isn't needed
##########
settings.gradle.kts:
##########
@@ -225,6 +225,7 @@ include(":sdks:java:io:file-based-io-tests")
include(":sdks:java:io:bigquery-io-perf-tests")
include(":sdks:java:io:cdap")
include(":sdks:java:io:csv")
+include(":sdks:java:io:datadog")
Review Comment:
in addition to this, please add it to test:
https://github.com/apache/beam/blob/82ebcb213b9610c9d42558046a66c641b290675a/build.gradle.kts#L341
and also please setup a PreCommit and add it in
https://github.com/apache/beam/blob/master/.github/workflows/README.md#precommit-jobs
we can copy paste from an existing precommit workflow like
https://github.com/apache/beam/blob/master/.github/workflows/beam_PreCommit_Java_Clickhouse_IO_Direct.yml
##########
sdks/java/io/datadog/build.gradle:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.module' }
+applyJavaNature(
+ automaticModuleName: 'org.apache.beam.sdk.io.datadog'
+)
+
+description = "Apache Beam :: SDKs :: Java :: IO :: Datadog"
+ext.summary = "IO to read and write to Datadog."
+
+dependencies {
+ implementation
enforcedPlatform(library.java.google_cloud_platform_libraries_bom)
+ implementation project(path: ":sdks:java:core", configuration: "shadow")
+ implementation library.java.vendored_guava_32_1_2_jre
+ implementation library.java.joda_time
+ implementation library.java.slf4j_api
+ implementation library.java.google_http_client
+ implementation library.java.google_code_gson
+ implementation library.java.auto_value_annotations
+ annotationProcessor library.java.auto_value
Review Comment:
This should already be handled by BeamModulePlugin:
https://github.com/apache/beam/blob/82ebcb213b9610c9d42558046a66c641b290675a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L1397
and not needed here
##########
sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogEvent.java:
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.datadog;
+
+import static
org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkNotNull;
+
+import com.google.auto.value.AutoValue;
+import javax.annotation.Nullable;
Review Comment:
Prefer to use checkframework Nullable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
