ML-dev-crypto commented on issue #37198: URL: https://github.com/apache/beam/issues/37198#issuecomment-3761435146
Hi — I can take this on. Please assign this issue to @ML-dev-crypto. Proposed fix Change the visibility of RequestResponseIO.withBackOffSupplier(...) from package-private to public so callers can set a custom BackOff supplier (for example, one that bounds retries by count or total time). Add unit tests verifying the supplier is stored and honored; add an integration-style test that demonstrates bounded retries stop after the configured limit. Add a short release-note / docs comment mentioning this API addition and link to this issue and #37176. Why The current package-private visibility prevents users from overriding the default FluentBackoff.DEFAULT (which has no bounds), causing effectively unlimited retries for retryable errors. Making the method public is the smallest, least-invasive change to let users supply a bounded backoff strategy. API change (minimal) Visibility change only: package-private -> public No behavioral change unless users call the new API Proposed PR title RequestResponseIO: make withBackOffSupplier public to allow bounded retry strategies (#37198) Proposed PR description Make RequestResponseIO.withBackOffSupplier public so callers can provide a SerializableSupplier<BackOff>. Add unit tests to validate the configured supplier is used and a bounded BackOff stops retrying. Reference #37198 and #37176 in the PR description. Note compatibility: API addition only (no breaking changes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
