tvalentyn commented on code in PR #37331:
URL: https://github.com/apache/beam/pull/37331#discussion_r2699752760
##########
sdks/python/container/piputil.go:
##########
@@ -81,7 +81,7 @@ func isPackageInstalled(pkgName string) bool {
}
// pipInstallPackage installs the given package, if present.
-func pipInstallPackage(ctx context.Context, logger *tools.Logger, files
[]string, dir, name string, force, optional bool, extras []string) error {
+func pipInstallPackage(ctx context.Context, logger *tools.Logger, files
[]string, dir, name string, force, optional, useBuildIsolation bool, extras
[]string) error {
Review Comment:
I would also introduce a variable NO_BUILD_ISOLATION or
PIP_NO_BUILD_ISOLATION in case it comes up again for other scenarios, so users
can disable build isolation across the board for any pip installation command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
