damccorm commented on code in PR #37349:
URL: https://github.com/apache/beam/pull/37349#discussion_r2709204728
##########
sdks/python/setup.py:
##########
@@ -497,6 +497,7 @@ def get_portability_package_data():
'google-cloud-recommendations-ai>=0.1.0,<0.11.0',
'google-cloud-aiplatform>=1.26.0, < 2.0',
'cloud-sql-python-connector>=1.18.2,<2.0.0',
+ 'pyasn1>=0.6.2',
Review Comment:
I kicked off the updater an extra time -
https://github.com/apache/beam/actions/runs/21179791602 - it should create a pr
to resolve this
##########
sdks/python/setup.py:
##########
@@ -497,6 +497,7 @@ def get_portability_package_data():
'google-cloud-recommendations-ai>=0.1.0,<0.11.0',
'google-cloud-aiplatform>=1.26.0, < 2.0',
'cloud-sql-python-connector>=1.18.2,<2.0.0',
+ 'pyasn1>=0.6.2',
Review Comment:
I would expect this to get automatically done the next time the dependency
updater runs, so we shouldn't need the explicit callout in setup.py
This is a bit of an antipattern since we'd keep this requirement even if the
underlying library which requires it removed the dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
