scwhittle commented on code in PR #37326:
URL: https://github.com/apache/beam/pull/37326#discussion_r2715924808
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -250,6 +249,9 @@ public ProcessContinuation run(
tracker,
interrupter,
watermarkEstimator);
+ // The PartitionEndRecord indicates that there are no more records
expected
+ // for this partition.
+ stopAfterQuerySucceeds = true;
Review Comment:
Given that is part of the API, I don't feel too concerned making the
assumption.
The alternative to have it handled with the exception handling is not
particularly simple because the query will complete on the first processing
without exception. It is only after the tracker advances the restriction to a
timestamp beyond the partition end, and the SDF is rescheduled and restarts a
query from that point that the exception will be thrown. That adds additional
latency to finalizing the partition and seems complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
