kennknowles commented on code in PR #37376:
URL: https://github.com/apache/beam/pull/37376#discussion_r2737279505
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema.proto:
##########
@@ -237,3 +237,23 @@ message MapTypeEntry {
message LogicalTypeValue {
FieldValue value = 1;
}
+
+// Information needed to represent a Coder of type SCHEMA.
+message SchemaCoderPayload {
+ // The schema to use for encoding corresponding Row types.
+ Schema schema = 1;
+
+ // Function mapping from underlying object to Row type.
+ FunctionSpec to_row_fn = 2;
+
+ // Function mapping from Row type to underlying object.
+ FunctionSpec from_row_fn = 3;
Review Comment:
I had the same comment in discussion about this. The URN of it will be
something like `beam:dofn:javasdk` so the URN of the FunctionSpec indicates the
SDK. Or anyhow that is my recollection of why I decided it was redundant to
have an environment. It is the nature of coders to be the boundary between
environments, so each environment can interpret the FunctionSpec. (like maybe
in some weird world the java sdk environment actually finds a way to use
`beam:dofn:pythonsdk`?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
