tianz101 commented on code in PR #37427:
URL: https://github.com/apache/beam/pull/37427#discussion_r2738853325
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/mapper/ChangeStreamRecordMapper.java:
##########
@@ -218,18 +218,28 @@ public class ChangeStreamRecordMapper {
* @param resultSet the change stream result set
* @param resultSetMetadata the metadata generated when reading the change
stream row
* @return a {@link List} of {@link ChangeStreamRecord} subclasses
+ * @throws InvalidProtocolBufferException
*/
public List<ChangeStreamRecord> toChangeStreamRecords(
PartitionMetadata partition,
ChangeStreamResultSet resultSet,
ChangeStreamResultSetMetadata resultSetMetadata) {
if (this.isPostgres()) {
- // In PostgresQL, change stream records are returned as JsonB.
+ // For `MUTABLE_KEY_RANGE` option, change stream records are returned as
protos.
+ if (resultSet.isProtoBytesChangeRecord()) {
Review Comment:
Maybe we have the getBytes(0) reflected here to match up getPgJsonb(0) so
that it is very clear
that we should only expect one column from the result set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
