damccorm commented on code in PR #37009:
URL: https://github.com/apache/beam/pull/37009#discussion_r2765844627
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/TimerInternals.java:
##########
@@ -211,19 +218,48 @@ public static TimerData of(
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
- TimeDomain domain) {
+ TimeDomain domain,
+ CausedByDrain causedByDrain) {
Review Comment:
https://github.com/apache/beam/pull/37505 should fix. I'm confused why this
didn't fail checks on this pr... That seems like the real problem here
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/TimerInternals.java:
##########
@@ -211,19 +218,48 @@ public static TimerData of(
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
- TimeDomain domain) {
+ TimeDomain domain,
+ CausedByDrain causedByDrain) {
Review Comment:
Because of how this object was previously constructed, this broke:
https://github.com/apache/beam/actions/runs/21685692093/job/62531968855
This is because previously, if you had 5 arguments, they resolved to this
function, with ordered arguments:
```
String timerId,
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
TimeDomain domain
```
after this change, if you have 5 arguments they resolve to a function below
with arguments:
```
StateNamespace namespace,
Instant timestamp,
Instant outputTimestamp,
TimeDomain domain,
CausedByDrain causedByDrain
```
This is just an internal change, but given how many callers there are, we
may have been better off preserving the previous ordering guarantees.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
