damccorm commented on code in PR #37505:
URL: https://github.com/apache/beam/pull/37505#discussion_r2766000164
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillTagEncodingV2Test.java:
##########
@@ -319,7 +319,13 @@ public void testTimerTag() {
new Instant(123),
new Instant(456),
timeDomain)
- : TimerData.of(TIMER_ID, namespace, new Instant(123), new
Instant(456), timeDomain);
+ : TimerData.of(
+ TIMER_ID,
+ namespace,
+ new Instant(123),
+ new Instant(456),
+ timeDomain,
+ TimerData.CausedByDrain.NORMAL);
Review Comment:
Context: https://github.com/apache/beam/pull/37009/changes#r2765834617
changed the API, and this reverts us back to the behavior before that was
merged (this test doesn't need any updated functionality)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
