gemini-code-assist[bot] commented on PR #37510: URL: https://github.com/apache/beam/pull/37510#issuecomment-3850737627
## Summary of Changes Hello @kishorepola, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the Kafka offset commitment process within Apache Beam's KafkaIO connector. Previously, the system would commit offsets for all topic-partitions, even if some were idle and their offsets hadn't changed. This behavior could lead to excessive metadata load on Kafka brokers. The implemented solution introduces in-memory tracking of the last committed offsets and ensures that only partitions with advanced offsets are committed, thereby reducing the commit load and improving overall system efficiency. ### Highlights * **Optimized Kafka Offset Commits**: Introduced a mechanism to track the last successfully committed offsets for each topic-partition, preventing redundant commits for idle partitions. * **Reduced Kafka Broker Load**: Modified the `commitCheckpointMark` method to only commit offsets that have advanced, significantly reducing metadata pressure on Kafka brokers, especially in large-scale deployments. * **Improved Efficiency**: The change avoids unnecessary `consumer.commitSync()` calls when no offsets have changed, leading to more efficient resource utilization. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java** * Added `java.util.HashMap` import to support the new offset tracking mechanism. * Introduced a new private field `lastCommittedOffsets` (a `Map<TopicPartition, Long>`) to store the last known committed offset for each topic-partition. * Refactored the `commitCheckpointMark` method to: 1) Filter out partitions with uninitialized offsets. 2) Compare the current `nextOffset` with the `lastCommittedOffsets` to identify only those partitions whose offsets have genuinely advanced. 3) Construct a map (`toCommit`) containing only the advanced offsets. 4) Skip the `consumer.commitSync()` call if `toCommit` is empty, avoiding unnecessary operations. 5) Update `lastCommittedOffsets` only after a successful `consumer.commitSync()` operation. </details> <details> <summary><b>Activity</b></summary> * The pull request was created by kishorepola to address high Kafka commit load due to redundant offset commits for idle partitions. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
