gemini-code-assist[bot] commented on PR #37528: URL: https://github.com/apache/beam/pull/37528#issuecomment-3857171292
## Summary of Changes Hello @AMOOOMA, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the queuing and synchronization logic within the `ModelManager` to mitigate lock contention, particularly when many threads are waiting to acquire a model. By transitioning from a broadcast-based notification system (`notify_all`) to a more precise, ticket-based approach that wakes only the next eligible thread, the changes aim to improve the fairness and efficiency of resource acquisition, especially under high load. ### Highlights * **Targeted Thread Notification**: Replaced `threading.Condition.notify_all()` with a mechanism to wake only the next thread in the queue, reducing contention and improving fairness. * **QueueTicket Introduction**: Introduced a `QueueTicket` class to encapsulate priority, ticket number, tag, and a dedicated `threading.Event` for individual thread waking, enabling more precise control over thread notifications. * **Efficient Cancellation Handling**: Added a `_cancelled_tickets` set and logic to efficiently remove cancelled requests from the head of the wait queue without requiring a full heap re-heapify operation. * **Refactored Waiting Logic**: Implemented `_wake_next_in_queue` and `_wait_in_queue` helper methods to streamline the queuing and notification process within the `acquire_model` method. * **Enhanced Timeout Test**: Updated the `test_model_manager_timeout` to simulate higher concurrency (1000 threads) and added a post-timeout check to verify the `ModelManager` remains functional after a timeout scenario. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/python/apache_beam/ml/inference/model_manager.py** * Introduced `QueueTicket` class with `priority`, `ticket_num`, `tag`, and `wake_event` attributes, and a custom `__lt__` method for heap ordering. * Added `_cancelled_tickets` set to `ModelManager` to track tickets that have been cancelled. * Implemented `_wake_next_in_queue` method to notify the next valid ticket in the priority queue. * Implemented `_wait_in_queue` method to allow a specific ticket to wait on its `wake_event`. * Modified `acquire_model` to create and use `QueueTicket` objects instead of raw tuples. * Replaced `self._cv.wait()` with `self._wait_in_queue(my_ticket)` for waiting threads. * Replaced `self._cv.notify_all()` with `self._wake_next_in_queue()` in relevant sections, including model release and priority re-evaluation. * Updated `_evict_to_make_space` to access the `tag` attribute directly from `QueueTicket` objects. * Improved cleanup logic in `acquire_model`'s `finally` block to mark cancelled tickets instead of searching and re-heapifying. * **sdks/python/apache_beam/ml/inference/model_manager_test.py** * Expanded `test_model_manager_timeout` to submit 1000 `acquire_model` calls concurrently. * Added a post-timeout check to ensure the `ModelManager` can still acquire and release models, verifying its continued functionality. </details> <details> <summary><b>Activity</b></summary> * The pull request includes a standard contribution checklist. * CI build statuses for Python, Java, and Go tests are displayed. * No human comments or reviews have been recorded yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
