pabloem commented on a change in pull request #12762:
URL: https://github.com/apache/beam/pull/12762#discussion_r492332731
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_io_metadata.py
##########
@@ -28,6 +28,11 @@
_VALID_CLOUD_LABEL_PATTERN = re.compile(r'^[a-z0-9\_\-]{1,63}$')
+def _sanitize_value(value):
+ """Sanitizes a value into a valid BigQuery label value."""
+ return re.sub('[^\w-]+', '', value.lower().replace('/', '-'))[0:63]
Review comment:
This is in bigquery_io_metadata. Thanks!
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1875,14 +1895,22 @@ def process(self, unused_element, signal):
temp_location = pcoll.pipeline.options.view_as(
GoogleCloudOptions).temp_location
gcs_location = self._get_destination_uri(temp_location)
+ job_name = pcoll.pipeline.options.view_as(GoogleCloudOptions).job_name
+ try:
+ step_name = self.label
Review comment:
This is set by the Python SDK as it expands transforms. It's definitely
not orthodox to rely on it, and a little unusual.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
