ahmedabu98 commented on code in PR #36296:
URL: https://github.com/apache/beam/pull/36296#discussion_r2774960466
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java:
##########
@@ -649,20 +632,30 @@ static void verifyDatasetPresence(DatasetService
datasetService, TableReference
}
static String getDatasetLocation(
- DatasetService datasetService, String projectId, String datasetId) {
- Dataset dataset;
+ DatasetService datasetService, String projectId, String datasetId)
+ throws IOException, InterruptedException {
Review Comment:
nit: why can't we throw a RuntimeException instead? and avoid having to
try-catch each time we call `getDatasetLocation` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
