tvalentyn commented on code in PR #37522: URL: https://github.com/apache/beam/pull/37522#discussion_r2784219092
########## sdks/python/apache_beam/options/pipeline_construction_options.py: ########## @@ -0,0 +1,60 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Context-scoped access to pipeline options during graph construction and +translation. + +This module provides thread-safe and async-safe access to PipelineOptions +using contextvars. +""" + +from contextlib import contextmanager +from contextvars import ContextVar +from typing import TYPE_CHECKING +from typing import Optional + +if TYPE_CHECKING: + from apache_beam.options.pipeline_options import PipelineOptions + +# The contextvar holding the current pipeline's options. +# Each thread and each asyncio task gets its own isolated copy. +_current_pipeline_options: ContextVar[Optional['PipelineOptions']] = ContextVar( + 'current_pipeline_options', default=None) Review Comment: since 'pipeline options' is such a common wordpair, current_pipeline_options reads like current_PO, instead of CP_options (which is what I think you are denoting). perhaps this can be simply pipeline_options, especially since we anticipate there is usually a single pipeline? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
