gemini-code-assist[bot] commented on PR #37560: URL: https://github.com/apache/beam/pull/37560#issuecomment-3878896631
## Summary of Changes Hello @derrickaw, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the JavaScript execution capabilities within Apache Beam's YAML module by replacing the `js2py` library with `pythonmonkey`. This change resolves compatibility issues, particularly with newer Python versions, and leverages a more actively maintained and robust JavaScript engine (Mozilla's SpiderMonkey) to enhance the reliability and security of JavaScript user-defined functions. The refactoring introduces a dedicated class for handling JavaScript callables, streamlining the integration and execution of JavaScript logic within Beam pipelines. ### Highlights * **JavaScript Engine Replacement**: Replaced the `js2py` library with `pythonmonkey` for executing JavaScript user-defined functions (UDFs) within Apache Beam's YAML module. * **Improved Compatibility and Maintenance**: Addressed limitations of `js2py`, such as incompatibility with Python 3.12 and lack of active maintenance, by adopting `pythonmonkey`, which utilizes Mozilla's actively developed SpiderMonkey engine. * **Refactored JavaScript Callable Handling**: Introduced a new `JavaScriptCallable` class to encapsulate the logic for loading and executing JavaScript functions, supporting expressions, callables, and file-based UDFs. * **Dependency Update**: Updated the `setup.py` file to remove `js2py` and include `pythonmonkey` as a dependency for the `yaml` extra. * **Test Migration**: Migrated existing unit tests to reflect the change from `js2py` to `pythonmonkey`. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/python/apache_beam/yaml/yaml_mapping.py** * Replaced `js2py` import with `pythonmonkey`. * Removed the `_CustomJsObjectWrapper` class and related `js2py` specific object conversion logic. * Introduced a new `JavaScriptCallable` class to encapsulate JavaScript function loading and execution. * Refactored `_expand_javascript_mapping_func` to utilize the new `JavaScriptCallable` and `pythonmonkey`'s `eval` function. * Added `_finalize_js_result` to coerce `pythonmonkey` objects to native Python types. * **sdks/python/apache_beam/yaml/yaml_udf_test.py** * Updated imports to use `pythonmonkey` instead of `js2py`. * Modified `unittest.skipIf` decorators to check for `pythonmonkey`'s presence. * **sdks/python/setup.py** * Removed `js2py` from the `apache_beam[yaml]` extra dependencies. * Added `pythonmonkey>=1.3.0` as a dependency for Python versions >= 3.8. </details> <details> <summary><b>Activity</b></summary> * No human activity has been recorded on this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
