shunping commented on code in PR #37502:
URL: https://github.com/apache/beam/pull/37502#discussion_r2795089143


##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java:
##########
@@ -125,6 +134,36 @@ public static boolean isWildcard(GcsPath spec) {
             rewriteDataOpBatchLimit,
             gcsCountersOptions.delegate,
             gcsOptions);
+    this.delegateV2 = null;
+  }
+
+  @VisibleForTesting
+  GcsUtil(
+      Storage storageClient,
+      HttpRequestInitializer httpRequestInitializer,
+      ExecutorService executorService,
+      Boolean shouldUseGrpc,
+      Credentials credentials,
+      @Nullable Integer uploadBufferSizeBytes,
+      @Nullable Integer rewriteDataOpBatchLimit,
+      GcsCountersOptions gcsCountersOptions,
+      GcsOptions gcsOptions,
+      Boolean shouldUseV2) {

Review Comment:
   Sure, but notice that that this is a package-private constructor and it is 
not supposed to be called directly by users.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to