junaiddshaukat commented on PR #37553: URL: https://github.com/apache/beam/pull/37553#issuecomment-3892168618
> @junaiddshaukat These changes look good. Can you check on the failing tests? Hi @johnjcasey, thanks for the review and approval! I checked all 3 failing tests — none are related to this PR's changes: **1. Java Unit Tests (windows-latest)** — Failing after 27m **2. Java Wordcount Direct Runner (windows-latest)** — Failing after 33m These are Windows CI runner failures that are known to be flaky across the repo. They're unrelated to KafkaIO. **3. PreCommit Java Kafka IO Direct** — The only test that failed in the Kafka IO suite is `KafkaIOTest.testUnreachableKafkaBrokers`, which tests the **legacy `KafkaUnboundedReader`** path (non-SDF). It tries to connect to `8.8.8.8:9092` (Google's public DNS as a fake broker) and expects a timeout — this is a network-dependent flaky test. My changes only touch the SDF path (`GenerateKafkaSourceDescriptor` and `WatchForKafkaTopicPartitions`), which is a completely different code path. I verified locally: 159 tests ran, 158 passed, 2 skipped, and the only failure was the same `testUnreachableKafkaBrokers` — which also fails on a clean master checkout. retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
