gemini-code-assist[bot] commented on PR #37582:
URL: https://github.com/apache/beam/pull/37582#issuecomment-3892649973
## Summary of Changes
Hello @Abacn, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull
request and will post my feedback shortly. In the meantime, here's a summary to
help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the Python Flink runner test suite by
enabling the execution of tests against the Flink DataStream API for batch
processing. It introduces a new configuration option to control this behavior
and sets up a dedicated test task to validate its functionality. Additionally,
it refines the Java command-line arguments for the Flink job server to be more
platform-aware and cleans up a redundant Gradle setting.
### Highlights
* **Flink DataStream API Testing**: Introduced a new command-line argument
`--use_data_stream_for_batch` to enable Flink DataStream API for batch
pipelines in Python Flink runner tests, and added a new test task to
specifically run these tests.
* **Conditional Java Options**: Modified the Flink job server's Java command
to conditionally apply the `-XX:-UseContainerSupport` flag only when running on
Linux, optimizing container support.
* **Gradle Configuration Cleanup**: Removed an unnecessary
`outputs.upToDateWhen { false }` configuration from the SQL expansion service's
`shadowJar` task, streamlining the build process.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help
**Gemini Code Assist** learn from your team's feedback. This makes future code
reviews more consistent and personalized to your project's style. **Click
[here](https://codeassist.google/code-review/login) to enable Memory in your
admin console.**
<details>
<summary><b>Changelog</b></summary>
* **sdks/java/extensions/sql/expansion-service/build.gradle**
* Removed `outputs.upToDateWhen { false }` from the `shadowJar`
configuration.
* **sdks/python/apache_beam/runners/portability/flink_runner_test.py**
* Added `platform` import.
* Introduced `--use_data_stream_for_batch` argument to control Flink
DataStream API usage for batch pipelines.
* Modified Java subprocess command to conditionally include
`-XX:-UseContainerSupport` only on Linux.
* Propagated the `use_data_stream_for_batch` flag to Flink runner
options.
* **sdks/python/test-suites/portable/common.gradle**
* Modified `createFlinkRunnerTestTask` to accept a
`useDataStreamForBatch` parameter.
* Conditionally added `--use_data_stream_for_batch` option and modified
task name based on the new parameter.
* Added a new Flink compatibility matrix test task for LOOPBACK worker
type using the DataStream API.
</details>
<details>
<summary><b>Ignored Files</b></summary>
* **Ignored by pattern:** `.github/workflows/**` (1)
* .github/workflows/beam_PostCommit_Python_Portable_Flink.yml
</details>
<details>
<summary><b>Activity</b></summary>
* The pull request is currently in a draft state, indicating ongoing
development.
* The description is a placeholder, suggesting that detailed context or
specific issues addressed are yet to be provided by the author.
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation
page](https://developers.google.com/gemini-code-assist/docs/review-github-code),
here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment
using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a
summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull
request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current
pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged,
both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository
maintainers can create a configuration file and/or provide a custom code review
style guide (such as PEP-8 for Python) by creating and adding files to a
`.gemini/` folder in the base of the repository. Detailed instructions can be
found
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances
where its feedback is incorrect or counter productive. You can react with
:thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're
interested in giving your feedback about your experience with Gemini Code
Assist for Github and other Google products, sign up
[here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code
reviews directly in the IDE at no cost with the [Gemini Code Assist IDE
Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy),
[Generative AI Prohibited Use
Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of
Service](https://policies.google.com/terms), and learn how to configure Gemini
Code Assist in GitHub
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
Gemini can make mistakes, so double check it and [use code with
caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
